- Posts: 3
- Thank you received: 0
Suggestions for 1.7.4 and higher
11 years 7 months ago - 11 years 7 months ago #12463
by MrX1980
Suggestions for 1.7.4 and higher was created by MrX1980
Suggestions for future versions based on 1.7.3
A)
header.php / Line 7-9:
header.php / Line 15:
header.php / Line 18:
header.php / Line 32+33:
replace language_english.php with language.php and remove/delete language.php
C)
language_english.php
add
language_german.php
add
D) Many messages are not translated via language_...php
E) Don't use numbers please. Give it meaningful names.
$error1 = $Error_Long_Name
$error2 = $Error_Long_Email
$error3 = $Error_Invalid_Email
...
F)
guestbook.php / Line 66-69
guestbook.php / Line 94
G)
add.php / Line 74
move it to language_....php (for regional preferences)
H)
list.php / Line 30+31
move it to config.php
I) I see to many <font ...> tags in the code. Use more the style.css
... to be continued.
A)
header.php / Line 7-9:
Code:
old:
include("gbclass.php");
include("config.php");
include("language/$default_language");
new:
require_once("gbclass.php");
require_once("config.php");
require_once("language/$default_language");
header.php / Line 15:
Code:
old:
<title>Powered by DigiOz Guestbook Version 1.7.2</title>
new:
<title>Powered by DigiOz Guestbook</title>
header.php / Line 18:
Code:
old:
<body bgcolor="#FFFFFF" text="#000000" link="#8080ff" vlink="#0000ff" alink="#ffff00"><center>
new:
<body><center>
Code:
old:
<td><font size="1">Enter Search <b>WORD</b>:</font></td>
<td align=left><input type="text" name="search_term" size=20 maxlength=50><input type=submit value="Find Now!"></td>
new:
<td><font size="1"><?php echo $Enter_Search_Word ?></font></td>
<td align=left><input type="text" name="search_term" size=20 maxlength=50><input type=submit value="<?php echo $Find_Now ?>"></td>
replace language_english.php with language.php and remove/delete language.phpC)
language_english.php
add
Code:
$Enter_Search_Word = "Enter Search WORD:";
$Find_Now = "Find Now!";
$Verify = "Verify";
$Bold = "Bold";
$Underline = "Underline";
$Italic = "Italic";
$Center = "Center";
language_german.php
add
Code:
$Enter_Search_Word = "Suche nach:";
$Find_Now = "Suche";
$Verify = "Abgleich";
$Bold = "Fett";
$Underline = "Unterstrichen";
$Italic = "Kursiv";
$Center = "Zentriert";
D) Many messages are not translated via language_...php
E) Don't use numbers please. Give it meaningful names.
$error1 = $Error_Long_Name
$error2 = $Error_Long_Email
$error3 = $Error_Invalid_Email
...
F)
guestbook.php / Line 66-69
Code:
old:
<td><input type="button" class="button" value=" Bold " style="font-weight:bold; width: 50px" onClick="javascript:bbcode('[b] [/b]')"></td>
<td><input type="button" class="button" value=" Underline " style="font-weight:bold; width: 80px" onClick="javascript:bbcode('[u] [/u]')"></td>
<td><input type="button" class="button" value=" Italic " style="font-weight:bold; width: 50px" onClick="javascript:bbcode('[i] [/i]')"></td>
<td><input type="button" class="button" value=" Center " style="font-weight:bold; width: 70px" onClick="javascript:bbcode('[center] [/center]')"></td>
new:
<td><input type="button" class="button" value=" <?php echo $Bold; ?> " style="font-weight:bold; width: 50px" onClick="javascript:bbcode('[b] [/b]')"></td>
<td><input type="button" class="button" value=" <?php echo $Underline; ?> " style="font-weight:bold; width: 100px" onClick="javascript:bbcode('[u] [/u]')"></td>
<td><input type="button" class="button" value=" <?php echo $Italic; ?> " style="font-weight:bold; width: 50px" onClick="javascript:bbcode('[i] [/i]')"></td>
<td><input type="button" class="button" value=" <?php echo $Center; ?> " style="font-weight:bold; width: 70px" onClick="javascript:bbcode('[center] [/center]')"></td>
guestbook.php / Line 94
Code:
old:
echo '<tr><td><p><b><font size="2">Verify:</font></b></p></td><td><input type="text" name="txtNumber" size="20" value=""><img src="random.php"></td></tr>';
new:
echo '<tr><td><p><b><font size="2">'.$Verify.'</font></b></p></td><td><input type="text" name="txtNumber" size="20" value=""><img src="random.php"></td></tr>';
G)
add.php / Line 74
Code:
$date = date("D m/j/y g:iA");
H)
list.php / Line 30+31
Code:
// Setting the default values for number of records per page -------------------------
$perpage = 10;
I) I see to many <font ...> tags in the code. Use more the style.css
... to be continued.
Last edit: 11 years 7 months ago by MrX1980.
Please Log in or Create an account to join the conversation.
11 years 7 months ago #12472
by MrX1980
Do you have a roadmap or something else for new versions ?
Replied by MrX1980 on topic Suggestions for 1.7.4 and higher
Not on all "places", it was only done for the footer.php but not the header.phpPete wrote: Your suggestion about "Powered by" text has already been implemented in version 1.7.3.
Do you have a roadmap or something else for new versions ?
Please Log in or Create an account to join the conversation.
Time to create page: 0.119 seconds